From 5f13859873a45424a345186e8b9913a8c4cb834f Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Mon, 23 Sep 2019 10:50:21 +0800 Subject: [PATCH] lavf/4xm: fix memory leak in error handing path need to free the header in error path. Reviewed-by: Michael Niedermayer Signed-off-by: Jun Zhao --- libavformat/4xm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/4xm.c b/libavformat/4xm.c index a984fc9fdf..a6101a92ec 100644 --- a/libavformat/4xm.c +++ b/libavformat/4xm.c @@ -241,7 +241,8 @@ static int fourxm_read_header(AVFormatContext *s) size = AV_RL32(&header[i + 4]); if (size > header_size - i - 8 && (fourcc_tag == vtrk_TAG || fourcc_tag == strk_TAG)) { av_log(s, AV_LOG_ERROR, "chunk larger than array %d>%d\n", size, header_size - i - 8); - return AVERROR_INVALIDDATA; + ret = AVERROR_INVALIDDATA; + goto fail; } if (fourcc_tag == std__TAG) {