flacdec: Add a check for small buffer size. This ensures reading as

much of the frame header as possible without excluding the smallest
possible FLAC frame.  It also fixes a false positive warning message
that was being emitted at the end of decoding.

Originally committed as revision 17816 to svn://svn.ffmpeg.org/ffmpeg/trunk
release/0.6
Justin Ruggles 16 years ago
parent c51997297a
commit 5ef4fa87b3
  1. 5
      libavcodec/flacdec.c

@ -639,6 +639,11 @@ static int flac_decode_frame(AVCodecContext *avctx,
init_get_bits(&s->gb, buf, buf_size*8); init_get_bits(&s->gb, buf, buf_size*8);
/* check that there is at least the smallest decodable amount of data.
this amount corresponds to the smallest valid FLAC frame possible. */
if (buf_size < 24)
goto end;
/* check for inline header */ /* check for inline header */
if (show_bits_long(&s->gb, 32) == MKBETAG('f','L','a','C')) { if (show_bits_long(&s->gb, 32) == MKBETAG('f','L','a','C')) {
if (metadata_parse(s)) { if (metadata_parse(s)) {

Loading…
Cancel
Save