avformat/dss: Use AV_DICT_DONT_STRDUP_VAL to save a malloc+memcpy

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
pull/336/head
Andreas Rheinhardt 5 years ago
parent 3ab16d091e
commit 557668e8cb
  1. 10
      libavformat/dss.c

@ -103,15 +103,11 @@ static int dss_read_metadata_string(AVFormatContext *s, unsigned int offset,
ret = avio_read(s->pb, value, size); ret = avio_read(s->pb, value, size);
if (ret < size) { if (ret < size) {
ret = ret < 0 ? ret : AVERROR_EOF; av_free(value);
goto exit; return ret < 0 ? ret : AVERROR_EOF;
} }
ret = av_dict_set(&s->metadata, key, value, 0); return av_dict_set(&s->metadata, key, value, AV_DICT_DONT_STRDUP_VAL);
exit:
av_free(value);
return ret;
} }
static int dss_read_header(AVFormatContext *s) static int dss_read_header(AVFormatContext *s)

Loading…
Cancel
Save