From 4ebd422c04849a21a6bb2128a715979e8067e6a6 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 12 Apr 2012 17:56:57 -0700 Subject: [PATCH] mov: fix leaking memory with multiple drefs. Instead of allocating over the original, free first. MOVStreamContext is zero initialized so no double free will occur. Same style as other fixes for the same problem in this file. Signed-off-by: Dale Curtis Signed-off-by: Luca Barbato --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 046c030bcf..5787f1aeb0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -387,6 +387,7 @@ static int mov_read_dref(MOVContext *c, AVIOContext *pb, MOVAtom atom) entries = avio_rb32(pb); if (entries >= UINT_MAX / sizeof(*sc->drefs)) return AVERROR_INVALIDDATA; + av_free(sc->drefs); sc->drefs = av_mallocz(entries * sizeof(*sc->drefs)); if (!sc->drefs) return AVERROR(ENOMEM);