avcodec/vorbisdec: Fix memleak, call cleanup on memory allocation failure

Fixes CID1258478, CID1258476, CID1258475 Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
10 years ago · 2234a1cd16
parent 8559a71415
commit 2234a1cd16
1 changed files with 4 additions and 2 deletions
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@ -383,8 +383,10 @@ static int vorbis_parse_setup_hdr_codebooks(vorbis_context *vc)
                codebook_setup->codevectors =
                    av_mallocz_array(used_entries, codebook_setup->dimensions *
                               sizeof(*codebook_setup->codevectors));
-                if (!codebook_setup->codevectors)
-                    return AVERROR(ENOMEM);
+                if (!codebook_setup->codevectors) {
+                    ret = AVERROR(ENOMEM);
+                    goto error;
+                }
            } else
                codebook_setup->codevectors = NULL;