lavf: Remove a now useless parameter to ffurl_register_protocol

This was added in 9b07a2dc02 as an ABI hack to allow older
code built with lavf 52 to register protocols even if the size
of the URLProtocol struct was increased. Later, registering
protocols from outside of lavf was removed and this workaround
isn't needed any longer since lavf 53.

This removes an unchecked malloc and a memory leak for the cases
when this workaround actually was used - which it hasn't since
lavf 53.

Signed-off-by: Martin Storsjö <martin@martin.st>
pull/45/head
Martin Storsjö 11 years ago
parent 4f2d8968c0
commit 0c5f839693
  1. 3
      libavformat/allformats.c
  2. 7
      libavformat/avio.c
  3. 4
      libavformat/url.h

@ -45,8 +45,7 @@
{ \ { \
extern URLProtocol ff_##x##_protocol; \ extern URLProtocol ff_##x##_protocol; \
if (CONFIG_##X##_PROTOCOL) \ if (CONFIG_##X##_PROTOCOL) \
ffurl_register_protocol(&ff_##x##_protocol, \ ffurl_register_protocol(&ff_##x##_protocol); \
sizeof(ff_##x##_protocol)); \
} }
void av_register_all(void) void av_register_all(void)

@ -94,14 +94,9 @@ const char *avio_enum_protocols(void **opaque, int output)
return avio_enum_protocols(opaque, output); return avio_enum_protocols(opaque, output);
} }
int ffurl_register_protocol(URLProtocol *protocol, int size) int ffurl_register_protocol(URLProtocol *protocol)
{ {
URLProtocol **p; URLProtocol **p;
if (size < sizeof(URLProtocol)) {
URLProtocol *temp = av_mallocz(sizeof(URLProtocol));
memcpy(temp, protocol, size);
protocol = temp;
}
p = &first_protocol; p = &first_protocol;
while (*p != NULL) while (*p != NULL)
p = &(*p)->next; p = &(*p)->next;

@ -224,10 +224,8 @@ int ffurl_shutdown(URLContext *h, int flags);
/** /**
* Register the URLProtocol protocol. * Register the URLProtocol protocol.
*
* @param size the size of the URLProtocol struct referenced
*/ */
int ffurl_register_protocol(URLProtocol *protocol, int size); int ffurl_register_protocol(URLProtocol *protocol);
/** /**
* Check if the user has requested to interrup a blocking function * Check if the user has requested to interrup a blocking function

Loading…
Cancel
Save