avcodec/x86/diracdsp: Fix incorrect src addressing in dequant_subband_32()

Fixes: Segfault (not reproducable with asm, which made this hard to debug) Fixes: decoding errors Fixes: 19854/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5729372837511168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
5 years ago · 0694b60b7b
parent 20916f9bc4
commit 0694b60b7b
1 changed files with 2 additions and 1 deletions
--- a/libavcodec/x86/diracdsp.asm
+++ b/libavcodec/x86/diracdsp.asm
@ -294,8 +294,9 @@ cglobal dequant_subband_32, 7, 7, 4, src, dst, stride, qf, qs, tot_v, tot_h

    add    srcq, mmsize
    add    dstq, mmsize
-    sub    tot_hd, 4
+    sub    tot_hq, 4
    jg     .loop_h
+    lea    srcq, [srcq + 4*tot_hq]

    add    r3, strideq
    dec    tot_vd